Messages in this thread | | | From | Arnd Bergmann <> | Subject | Re: [PATCH] unicore32 framebuffer driver fix: make videomemory kmalloc-ed and floatable | Date | Tue, 29 Mar 2011 16:42:49 +0200 |
| |
On Tuesday 29 March 2011, Guan Xuetao wrote: > > 1. make videomemory kmalloc-ed in fb-puv3.c > 2. remove resource reservation for old fixed UNIGFX_MMAP & UVC_MMAP space > 3. remove unused PKUNTIY_UNIGFX_MMAP_BASE, PKUNITY_UNIGFX_MMAP_SIZE, > PKUNITY_UVC_MMAP_BASE, PKUNITY_UVC_MMAP_SIZE and KUSER_UNIGFX_BASE > 4. remove unused header linux/vmalloc.h in fb-puv3.c > > Signed-off-by: Guan Xuetao <gxt@mprc.pku.edu.cn>
How does this work? UNIFB_MEMSIZE seems to be 4 MB, much more than the maximum of 128 KB that kmalloc can allocate.
Shouldn't this use get_free_pages() instead of kmalloc?
Arnd
| |