Messages in this thread Patch in this message | | | Date | Mon, 28 Mar 2011 13:40:16 -0700 | From | Randy Dunlap <> | Subject | [PATCH] ubifs: fix kconfig dependency warning |
| |
From: Randy Dunlap <randy.dunlap@oracle.com>
Fix another kconfig dependency warning, this time in ubifs.
warning: (UBIFS_FS_DEBUG && LOCKDEP && LATENCYTOP) selects KALLSYMS_ALL which has unmet direct dependencies (DEBUG_KERNEL && KALLSYMS)
Without this patch, we can have: # CONFIG_KALLSYMS is not set CONFIG_KALLSYMS_ALL=y which is useless (does nothing unless KALLSYMS is enabled).
However, ubifs builds successfully with or without this patch, and it builds with this line completely deleted, so what was this 'select' for? Just developer convenience?
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com> Cc: Artem Bityutskiy <dedekind1@gmail.com> Cc: Adrian Hunter <adrian.hunter@nokia.com> Cc: linux-mtd@lists.infradead.org --- fs/ubifs/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-2.6.38-git18.orig/fs/ubifs/Kconfig +++ linux-2.6.38-git18/fs/ubifs/Kconfig @@ -47,7 +47,7 @@ config UBIFS_FS_DEBUG bool "Enable debugging support" depends on UBIFS_FS select DEBUG_FS - select KALLSYMS_ALL + select KALLSYMS_ALL if DEBUG_KERNEL && KALLSYMS help This option enables UBIFS debugging support. It makes sure various assertions, self-checks, debugging messages and test modes are compiled
| |