lkml.org 
[lkml]   [2011]   [Mar]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [RFC] checkpatch: add option to change warning return value.
On Tue, Mar 22, 2011 at 04:22:46PM -0700, Sarah Sharp wrote:
>
> BTW, I'm not a perl hacker, and I don't really understand the reporting code,
> so someone who knows it (Andy?) should make the correct patch. I didn't notice
> before sending, but right now the warning count reporting is bogus, although
> the warnings don't make the script return an error code:
>

>
>
> Note that second-to-last patch should have said 3 warnings. So my patch needs
> to be changed, but I really do want this functionality.
>

> > @@ -1096,6 +1099,9 @@ sub report {
> >
> > push(our @report, $line);
> >
> > + if ($lazy == 1) {
> > + return 0;
> > + }
> > return 1;
> > }
> > sub report_dump {

Instead of this hunk, have:


diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 58848e3..54ec3d9 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -316,7 +316,7 @@ for my $filename (@ARGV) {
}
close($FILE);
if (!process($filename)) {
- $exit = 1;
+ $exit = 1 if (!$lazy);
}
@rawlines = ();
@lines = ();

-- Steve



\
 
 \ /
  Last update: 2011-03-23 02:43    [W:0.065 / U:0.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site