Messages in this thread | | | Date | Thu, 24 Mar 2011 08:40:10 -0700 | From | Sarah Sharp <> | Subject | Re: [RFC] checkpatch: add option to change warning return value. |
| |
On Tue, Mar 22, 2011 at 09:41:17PM -0400, Steven Rostedt wrote: > On Tue, Mar 22, 2011 at 04:22:46PM -0700, Sarah Sharp wrote: > > > @@ -1096,6 +1099,9 @@ sub report { > > > > > > push(our @report, $line); > > > > > > + if ($lazy == 1) { > > > + return 0; > > > + } > > > return 1; > > > } > > > sub report_dump { > > Instead of this hunk, have: > > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl > index 58848e3..54ec3d9 100755 > --- a/scripts/checkpatch.pl > +++ b/scripts/checkpatch.pl > @@ -316,7 +316,7 @@ for my $filename (@ARGV) { > } > close($FILE); > if (!process($filename)) { > - $exit = 1; > + $exit = 1 if (!$lazy); > } > @rawlines = (); > @lines = ();
Hmm, but isn't that going to skip returning an exit value if there's an error as well? I really do want it to fail if there's an error, just not if there's a warning.
Sarah Sharp
| |