lkml.org 
[lkml]   [2011]   [Mar]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] x86, UV: Fix NMI handler for UV platforms
    On 03/21/2011 07:43 PM, Cyrill Gorcunov wrote:
    ...
    >
    > I think Jack might need to setup priority for his notifier, like
    >
    > static struct notifier_block uv_dump_stack_nmi_nb = {
    > .notifier_call = uv_handle_nmi,
    > .priority = NMI_LOCAL_HIGH_PRIOR+1,
    > };
    >
    > so it would be called before perf nmi. Don, am I right?
    >
    > Since for perf nmis we do have
    >
    > static __read_mostly struct notifier_block perf_event_nmi_notifier = {
    > .notifier_call = perf_event_nmi_handler,
    > .next = NULL,
    > .priority = NMI_LOCAL_LOW_PRIOR,
    > };
    >

    I must admit I've missed the fact that Jack has tried NMIs priorities, right?
    x86_platform_ops seems to be a cleaner indeed (btw I think p4 pmu kgdb issue
    is exactly the same problem) but same time this might end up in over-swelled
    ideas behind this small code snippet. Dunno. Probably we need some per-cpu
    system status for nmi reasons other than unknown nmis...

    --
    Cyrill


    \
     
     \ /
      Last update: 2011-03-21 18:07    [W:0.019 / U:92.932 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site