[lkml]   [2011]   [Mar]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] x86, UV: Fix NMI handler for UV platforms
On 03/21/2011 07:26 PM, Cyrill Gorcunov wrote:
>> Such code is extremely ugly. Please *reduce* the number of is_uv_system() type
>> of hacks in core x86 code, not increase it!
>> Any reason why a higher priority for the UV NMI handler cannot solve the 'perf
>> eats the NMI' problem?
>> Thanks,
>> Ingo
> Yeah, Don has made priority system for NMI notifiers. Need to look in.

I think Jack might need to setup priority for his notifier, like

static struct notifier_block uv_dump_stack_nmi_nb = {
.notifier_call = uv_handle_nmi,
.priority = NMI_LOCAL_HIGH_PRIOR+1,
so it would be called before perf nmi. Don, am I right?

Since for perf nmis we do have

static __read_mostly struct notifier_block perf_event_nmi_notifier = {
.notifier_call = perf_event_nmi_handler,
.next = NULL,
.priority = NMI_LOCAL_LOW_PRIOR,

 \ /
  Last update: 2011-03-21 17:59    [from the cache]
©2003-2014 Jasper Spaans. hosted at Digital Ocean