Messages in this thread | | | Date | Wed, 02 Mar 2011 02:45:17 -0500 | From | Jeff Garzik <> | Subject | Re: [PATCH #upstream-fixes] libata: fix hotplug for drivers which don't implement LPM |
| |
On 02/24/2011 01:30 PM, Tejun Heo wrote: > ata_eh_analyze_serror() suppresses hotplug notifications if LPM is > being used because LPM generates spurious hotplug events. It compared > whether link->lpm_policy was different from ATA_LPM_MAX_POWER to > determine whether LPM is enabled; however, this is incorrect as for > drivers which don't implement LPM, lpm_policy is always > ATA_LPM_UNKNOWN. This disabled hotplug detection for all drivers > which don't implement LPM. > > Fix it by comparing whether lpm_policy is greater than > ATA_LPM_MAX_POWER. > > Signed-off-by: Tejun Heo<tj@kernel.org> > Cc: stable@kernel.org
applied, though putting this into 2.6.38.1 is preferred to changing this at -rc7... stable@ cc'd.
| |