Messages in this thread | | | Date | Wed, 2 Mar 2011 22:43:54 +0300 | From | Vasiliy Kulikov <> | Subject | Re: [PATCH v2] net: don't allow CAP_NET_ADMIN to load non-netdev kernel modules |
| |
On Wed, Mar 02, 2011 at 12:39 -0700, Jake Edge wrote: > > @@ -1765,4 +1765,4 @@ module_exit(ipgre_fini); > > MODULE_LICENSE("GPL"); > > MODULE_ALIAS_RTNL_LINK("gre"); > > MODULE_ALIAS_RTNL_LINK("gretap"); > > -MODULE_ALIAS("gre0"); > > +MODULE_ALIAS_NETDEV("gre0"); > > that is, instead of replacing MODULE_ALIAS("gre0") with the NETDEV > version, don't you want both for backward compatibility?
The networking script will run with CAP_NET_ADMIN, this would request netdev-gre0 and load ip_gre.
-- Vasiliy Kulikov http://www.openwall.com - bringing security into open computing environments
| |