Messages in this thread | | | Date | Wed, 2 Mar 2011 12:49:36 -0700 | From | Jake Edge <> | Subject | Re: [PATCH v2] net: don't allow CAP_NET_ADMIN to load non-netdev kernel modules |
| |
On Wed, 2 Mar 2011 22:43:54 +0300 Vasiliy Kulikov wrote: > On Wed, Mar 02, 2011 at 12:39 -0700, Jake Edge wrote: > > > @@ -1765,4 +1765,4 @@ module_exit(ipgre_fini); > > > MODULE_LICENSE("GPL"); > > > MODULE_ALIAS_RTNL_LINK("gre"); > > > MODULE_ALIAS_RTNL_LINK("gretap"); > > > -MODULE_ALIAS("gre0"); > > > +MODULE_ALIAS_NETDEV("gre0"); > > > > that is, instead of replacing MODULE_ALIAS("gre0") with the NETDEV > > version, don't you want both for backward compatibility? > > The networking script will run with CAP_NET_ADMIN, this would request > netdev-gre0 and load ip_gre.
and on systems that today use CAP_SYS_MODULE (or really the full set of capabilities cuz they are running as root)? won't those try to load gre0 and fail because that alias doesn't exist?
jake
-- Jake Edge - LWN - jake@lwn.net - http://lwn.net
| |