Messages in this thread | | | From | Arnd Bergmann <> | Subject | Re: [PATCH 1/3] tty: serial: Use hub6_serial_X when CONFIG_SERIAL_8250_HUB6 is defined | Date | Fri, 11 Mar 2011 15:54:38 +0100 |
| |
On Friday 11 March 2011, Alan Cox wrote: > > or some variation of this. It's fine as long as this code never gets > > called, but incorrect nonetheless. > > I disagree - the WARN(1) is certainly correct.
Yes. I wrote this before I saw your other reply where you suggest the use of WARN_ON().
So while technically correct, I still tend to prefer build warnings over run-time warnings for things that we know about at build time.
> > I think it would be much cleaner if architectures that cannot do this > > would not have to define those functions and we could make sure that > > all drivers that do inb() have correct Kconfig dependencies. > > For 8250 the way to do that is to remove all the switches and port type > stuff and propogate to setting ->serial_in and ->serial_out rather than > splattering the code with ifdefs. At that point you'd have a "lib8250" or > similar and an 8250_io/pci driver.
Right, this absolutely makes sense. It's a lot more work than the originally suggested patch, but the result is much cleaner.
Arnd
| |