lkml.org 
[lkml]   [2011]   [Feb]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[patch -next] x86, microcode, AMD: signedness bug in generic_load_microcode()
    install_equiv_cpu_table() returns type int.  It uses negative error
    codes so using an unsigned type breaks the error handling.

    Signed-off-by: Dan Carpenter <error27@gmail.com>

    diff --git a/arch/x86/kernel/microcode_amd.c b/arch/x86/kernel/microcode_amd.c
    index 9fb8405..c561038 100644
    --- a/arch/x86/kernel/microcode_amd.c
    +++ b/arch/x86/kernel/microcode_amd.c
    @@ -246,7 +246,7 @@ generic_load_microcode(int cpu, const u8 *data, size_t size)
    struct ucode_cpu_info *uci = ucode_cpu_info + cpu;
    struct microcode_header_amd *mc_hdr = NULL;
    unsigned int mc_size, leftover;
    - unsigned long offset;
    + int offset;
    const u8 *ucode_ptr = data;
    void *new_mc = NULL;
    unsigned int new_rev = uci->cpu_sig.rev;

    \
     
     \ /
      Last update: 2011-02-18 10:19    [W:0.020 / U:89.344 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site