Messages in this thread | | | Subject | Re: [PATCH 2/2 v2] pci: use security_capable() when checking capablities during config space read | From | Eric Paris <> | Date | Mon, 14 Feb 2011 12:14:01 -0500 |
| |
On Thu, 2011-02-10 at 15:58 -0800, Chris Wright wrote: > * James Morris (jmorris@namei.org) wrote: > > What about these other users of cap_raised? > > > > drivers/block/drbd/drbd_nl.c: if (!cap_raised(nsp->eff_cap, CAP_SYS_ADMIN)) { > > drivers/md/dm-log-userspace-transfer.c: if (!cap_raised(nsp->eff_cap, CAP_SYS_ADMIN)) > > drivers/staging/pohmelfs/config.c: if (!cap_raised(nsp->eff_cap, CAP_SYS_ADMIN)) > > drivers/video/uvesafb.c: if (!cap_raised(nsp->eff_cap, CAP_SYS_ADMIN)) > > Those are a security_netlink_recv() variant. They should be converted > although makes sense as a different patchset. > > > Also, should this have a reported-by for Eric ? > > Yes it should, thanks. Below is patch with Reported-by added (seemed > overkill to respin the series; holler if that's perferred).
ACKed-by: Eric Paris <eparis@redhat.com>
on both of them.
-eric
| |