[lkml]   [2011]   [Feb]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH 2/2] pci: use security_capable() when checking capablities during config space read
    On Wed, 9 Feb 2011, Chris Wright wrote:

    > Eric Paris noted that commit de139a3 ("pci: check caps from sysfs file
    > open to read device dependent config space") caused the capability check
    > to bypass security modules and potentially auditing. Rectify this by
    > calling security_capable() when checking the open file's capabilities
    > for config space reads.

    What about these other users of cap_raised?

    drivers/block/drbd/drbd_nl.c: if (!cap_raised(nsp->eff_cap, CAP_SYS_ADMIN)) {
    drivers/md/dm-log-userspace-transfer.c: if (!cap_raised(nsp->eff_cap, CAP_SYS_ADMIN))
    drivers/staging/pohmelfs/config.c: if (!cap_raised(nsp->eff_cap, CAP_SYS_ADMIN))
    drivers/video/uvesafb.c: if (!cap_raised(nsp->eff_cap, CAP_SYS_ADMIN))

    Also, should this have a reported-by for Eric ?

    James Morris

     \ /
      Last update: 2011-02-10 09:25    [W:0.025 / U:5.068 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site