Messages in this thread | | | Date | Fri, 9 Dec 2011 10:55:10 +0530 | Subject | Re: [PATCH 1/2] mfd: add irq domain support for max8997 interrupts | From | Thomas Abraham <> |
| |
Hi Mark,
On 9 December 2011 10:11, Mark Brown <broonie@opensource.wolfsonmicro.com> wrote: > On Thu, Dec 08, 2011 at 09:57:38PM +0530, Thomas Abraham wrote: > > You should be sending this to Samuel for review as it's a MFD patch.
Ok. I will Cc Samuel for the v2 of this patchset.
> >> Add irq domain support for max8997 interrupts. All uses of irq_base in platform >> data and max8997 driver private data are removed. > > Removing irq_base from platform data isn't going to be helpful for > anyone using the driver on non-DT platforms as it's going to make it > impossible to find the interrupts.
All the consumers of the max8997 interrupts are the drivers for the sub-blocks of max8997. These drivers have access to 'irq_domain' member of 'struct max8997_dev', From irq_domain, the sub-block driver can get the irq_base and add one of the 'enum max8997_irq' offset when registering for interrupt notifications.
So irq_base from platform data and all uses of it was removed. All max8997 sub-block drivers should use the irq_base of the irq_domain.
Thanks for your review.
Regards, Thomas.
| |