[lkml]   [2011]   [Dec]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 2/2] regulator: add device tree support for max8997
Dear Mr. Park,

On 9 December 2011 08:00, Kyungmin Park <> wrote:
> On 12/9/11, Thomas Abraham <> wrote:
>> Add device tree based discovery support for max8997.
>> Cc: MyungJoo Ham <>
>> Cc: Rajendra Nayak <>
>> Cc: Rob Herring <>
>> Cc: Grant Likely <>
>> Signed-off-by: Thomas Abraham <>


>> +#else
>> +static int *max8997_i2c_parse_dt_pdata(struct device *dev
>> +                                     struct max8997_platform_data **pdata)
> It should be 'int' instead of 'int *'
> It's helpful to compile without CONFIG_OF.

I apologize for that. I compiled for exynos-dt first and then compiled
for origen board (which does not select CONFIG_OF). When compiling for
non-dt origen, I missed to notice that CONFIG_OF selection was left
over from the previous exynos-dt compile.

I have checked again without CONFIG_OF and found this issue as well as
two other errors/warnings.

Thanks. This was very helpful.


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

 \ /
  Last update: 2011-12-09 06:19    [from the cache]
©2003-2014 Jasper Spaans. hosted at Digital Ocean