lkml.org 
[lkml]   [2011]   [Dec]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 01/12] perf_events: add generic taken branch sampling support (v2)
From
On Mon, Dec 5, 2011 at 2:14 PM, Peter Zijlstra <peterz@infradead.org> wrote:
> On Fri, 2011-10-14 at 14:37 +0200, Stephane Eranian wrote:
>> +#define PERF_SAMPLE_BRANCH_PLM_ALL \
>> +       (PERF_SAMPLE_BRANCH_USER|\
>> +        PERF_SAMPLE_BRANCH_KERNEL)
>
> This PLM thing keeps popping up all over, I'm sure it stands for
> something, but for now it just hurts my eyes.
>
>
>> +               /* at least one branch bit must be set */
>> +               if (!(mask & ~PERF_SAMPLE_BRANCH_PLM_ALL))
>> +                       return -EINVAL;
>>
> Why? we can create counters with exclude_user && exclude_kernel as well,
> I mean, they're useless, but its perfectly valid.


I am fine with that change. I can drop this check.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2011-12-06 20:31    [W:0.236 / U:0.060 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site