lkml.org 
[lkml]   [2011]   [Dec]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 01/12] perf_events: add generic taken branch sampling support (v2)
    From
    Date
    On Fri, 2011-10-14 at 14:37 +0200, Stephane Eranian wrote:
    > +#define PERF_SAMPLE_BRANCH_PLM_ALL \
    > + (PERF_SAMPLE_BRANCH_USER|\
    > + PERF_SAMPLE_BRANCH_KERNEL)

    This PLM thing keeps popping up all over, I'm sure it stands for
    something, but for now it just hurts my eyes.


    > + /* at least one branch bit must be set */
    > + if (!(mask & ~PERF_SAMPLE_BRANCH_PLM_ALL))
    > + return -EINVAL;
    >
    Why? we can create counters with exclude_user && exclude_kernel as well,
    I mean, they're useless, but its perfectly valid.


    \
     
     \ /
      Last update: 2011-12-05 23:17    [W:0.019 / U:2.980 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site