Messages in this thread | | | Date | Tue, 27 Dec 2011 13:59:45 +0100 | From | Michal Hocko <> | Subject | Re: [PATCH] mm: hugetlb: add might_sleep() for gigantic page |
| |
On Fri 23-12-11 21:41:08, Hillf Danton wrote: > From: Hillf Danton <dhillf@gmail.com> > Subject: [PATCH] mm: hugetlb: add might_sleep() for gigantic page > > Like the case of huge page, might_sleep() is added for gigantic page, then > both are treated in same way.
Why do we need to call might_sleep here? There is cond_resched in the loop...
> > Cc: Michal Hocko <mhocko@suse.cz> > Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> > Cc: Andrew Morton <akpm@linux-foundation.org> > Signed-off-by: Hillf Danton <dhillf@gmail.com> > --- > > --- a/mm/hugetlb.c Tue Dec 20 21:26:30 2011 > +++ b/mm/hugetlb.c Fri Dec 23 21:19:18 2011 > @@ -401,6 +401,7 @@ static void copy_gigantic_page(struct pa > struct page *dst_base = dst; > struct page *src_base = src; > > + might_sleep(); > for (i = 0; i < pages_per_huge_page(h); ) { > cond_resched(); > copy_highpage(dst, src); > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/
-- Michal Hocko SUSE Labs SUSE LINUX s.r.o. Lihovarska 1060/12 190 00 Praha 9 Czech Republic
| |