lkml.org 
[lkml]   [2011]   [Dec]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] mm: hugetlb: add might_sleep() for gigantic page
On Tue 27-12-11 21:21:18, Hillf Danton wrote:
> On Tue, Dec 27, 2011 at 8:59 PM, Michal Hocko <mhocko@suse.cz> wrote:
> > On Fri 23-12-11 21:41:08, Hillf Danton wrote:
> >> From: Hillf Danton <dhillf@gmail.com>
> >> Subject: [PATCH] mm: hugetlb: add might_sleep() for gigantic page
> >>
> >> Like the case of huge page, might_sleep() is added for gigantic page, then
> >> both are treated in same way.
> >
> > Why do we need to call might_sleep here? There is cond_resched in the
> > loop...
> >
>
> IIUC it is the reason to add... and the comment says

cond_resched calls __might_sleep so there is no reason to call
might_sleep outside the loop as well.

--
Michal Hocko
SUSE Labs
SUSE LINUX s.r.o.
Lihovarska 1060/12
190 00 Praha 9
Czech Republic


\
 
 \ /
  Last update: 2011-12-27 14:33    [W:0.039 / U:0.704 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site