Messages in this thread Patch in this message | | | From | Jeff Layton <> | Subject | [PATCH] freezer: fix return value of freezable_schedule_timeout_killable | Date | Fri, 23 Dec 2011 21:00:54 -0500 |
| |
...it should return the return code from schedule_timeout_killable(), not the one from freezer_count().
All of the current callers ignore the return code so the bug is harmless but it's worth fixing.
Signed-off-by: Jeff Layton <jlayton@redhat.com> --- include/linux/freezer.h | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/include/linux/freezer.h b/include/linux/freezer.h index 30f06c2..96b5b59 100644 --- a/include/linux/freezer.h +++ b/include/linux/freezer.h @@ -122,9 +122,11 @@ static inline int freezer_should_skip(struct task_struct *p) /* Like schedule_timeout_killable(), but should not block the freezer. */ #define freezable_schedule_timeout_killable(timeout) \ ({ \ + long __retval; \ freezer_do_not_count(); \ - schedule_timeout_killable(timeout); \ + __retval = schedule_timeout_killable(timeout); \ freezer_count(); \ + __retval; \ }) /* -- 1.7.7.4
| |