Messages in this thread | | | From | "Hao, Xudong" <> | Date | Tue, 20 Dec 2011 18:47:22 +0800 | Subject | RE: [PATCH] intel-iommu: Add device info into list before doing context mapping |
| |
Hi, David
Do you have any comments for this patch?
Thanks, -Xudong
> -----Original Message----- > From: Hao, Xudong > Sent: Saturday, December 17, 2011 9:07 PM > To: 'iommu@lists.linux-foundation.org'; 'dwmw2@infradead.org' > Cc: 'linux-kernel@vger.kernel.org'; 'kvm@vger.kernel.org'; Zhang, Xiantao > Subject: [PATCH] intel-iommu: Add device info into list before doing context > mapping > > This patch add device info into list before do context mapping. Because device > info will be used by iommu_enable_dev_iotlb function, in this function, > pci_enable_ats would not be called without this patch, so ATS did not enable > while a PCI device which has ATS capability is assigned to a guest. > > Signed-off-by: Xudong Hao <xudong.hao@intel.com> > Signed-off-by: Xiantao Zhang <xiantao.zhang@intel.com> > --- > drivers/iommu/intel-iommu.c | 14 ++++++++------ > 1 files changed, 8 insertions(+), 6 deletions(-) > > diff --git a/drivers/iommu/intel-iommu.c b/drivers/iommu/intel-iommu.c index > c0c7820..f0b5d38 100644 > --- a/drivers/iommu/intel-iommu.c > +++ b/drivers/iommu/intel-iommu.c > @@ -2264,12 +2264,6 @@ static int domain_add_dev_info(struct > dmar_domain *domain, > if (!info) > return -ENOMEM; > > - ret = domain_context_mapping(domain, pdev, translation); > - if (ret) { > - free_devinfo_mem(info); > - return ret; > - } > - > info->segment = pci_domain_nr(pdev->bus); > info->bus = pdev->bus->number; > info->devfn = pdev->devfn; > @@ -2282,6 +2276,14 @@ static int domain_add_dev_info(struct > dmar_domain *domain, > pdev->dev.archdata.iommu = info; > spin_unlock_irqrestore(&device_domain_lock, flags); > > + ret = domain_context_mapping(domain, pdev, translation); > + if (ret) { > + list_del(&info->link); > + list_del(&info->global); > + free_devinfo_mem(info); > + return ret; > + } > + > return 0; > }
| |