lkml.org 
[lkml]   [2011]   [Dec]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: checkpatch.pl misreporting bugs with array fillings
Date
> On Fri, 2011-12-16 at 22:59 +0100, Marek Vasut wrote:
> > static const unsigned char pci_irq_swizzle[2][PCI_MAX_DEVICES] = {
> >
> > {0, 0, 0, 0, 0, 0, 0, 27, 27, [9 ... PCI_MAX_DEVICES - 1] = 0 },
> > {0, 0, 0, 0, 0, 0, 0, 29, 29, [9 ... PCI_MAX_DEVICES - 1] = 0 },
> >
> > };
>
> True.
>
> Andy will probably figure it out.
> He's the maintainer.
>
> Still, in this case all the 0's are unnecessary.
> I'd probably write that code as:
>
> static const unsigned char pci_irq_swizzle[2][PCI_MAX_DEVICES] = {
> { [7] = 27, [8] = 27 },
> { [7] = 29, [8] = 29 },
> };

I suspect this is some remnant of ancient code where the people writing it were
not sure if the memory under this is all-zeroes. (or the section this lands in
wasn't zeroed-out)

M


\
 
 \ /
  Last update: 2011-12-17 01:25    [W:0.525 / U:0.140 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site