Messages in this thread | | | Subject | Re: checkpatch.pl misreporting bugs with array fillings | From | Joe Perches <> | Date | Fri, 16 Dec 2011 16:15:55 -0800 |
| |
On Fri, 2011-12-16 at 22:59 +0100, Marek Vasut wrote: > static const unsigned char pci_irq_swizzle[2][PCI_MAX_DEVICES] = { > {0, 0, 0, 0, 0, 0, 0, 27, 27, [9 ... PCI_MAX_DEVICES - 1] = 0 }, > {0, 0, 0, 0, 0, 0, 0, 29, 29, [9 ... PCI_MAX_DEVICES - 1] = 0 }, > };
True.
Andy will probably figure it out. He's the maintainer.
Still, in this case all the 0's are unnecessary. I'd probably write that code as:
static const unsigned char pci_irq_swizzle[2][PCI_MAX_DEVICES] = { { [7] = 27, [8] = 27 }, { [7] = 29, [8] = 29 }, };
| |