lkml.org 
[lkml]   [2011]   [Dec]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] xfs: fix acl count validation in xfs_acl_from_disk()
    Date
    Commit fa8b18ed didn't prevent the integer overflow and possible
    memory corruption. "count" can go negative and bypass the check.

    Signed-off-by: Xi Wang <xi.wang@gmail.com>
    ---
    fs/xfs/xfs_acl.c | 2 +-
    1 files changed, 1 insertions(+), 1 deletions(-)

    diff --git a/fs/xfs/xfs_acl.c b/fs/xfs/xfs_acl.c
    index 76e4266..ac702a6 100644
    --- a/fs/xfs/xfs_acl.c
    +++ b/fs/xfs/xfs_acl.c
    @@ -39,7 +39,7 @@ xfs_acl_from_disk(struct xfs_acl *aclp)
    struct posix_acl_entry *acl_e;
    struct posix_acl *acl;
    struct xfs_acl_entry *ace;
    - int count, i;
    + unsigned int count, i;

    count = be32_to_cpu(aclp->acl_cnt);
    if (count > XFS_ACL_MAX_ENTRIES)
    --
    1.7.5.4


    \
     
     \ /
      Last update: 2011-12-12 23:01    [W:0.034 / U:0.448 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site