Messages in this thread Patch in this message | | | From | Xi Wang <> | Subject | [PATCH] input: signedness bug in cma3000_thread_irq() | Date | Mon, 12 Dec 2011 01:49:26 -0500 |
| |
The error check (intr_status < 0) didn't work because intr_status is a u8. Change its type to signed int.
Signed-off-by: Xi Wang <xi.wang@gmail.com> --- drivers/input/misc/cma3000_d0x.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/input/misc/cma3000_d0x.c b/drivers/input/misc/cma3000_d0x.c index 80793f1..06517e6 100644 --- a/drivers/input/misc/cma3000_d0x.c +++ b/drivers/input/misc/cma3000_d0x.c @@ -115,8 +115,8 @@ static void decode_mg(struct cma3000_accl_data *data, int *datax, static irqreturn_t cma3000_thread_irq(int irq, void *dev_id) { struct cma3000_accl_data *data = dev_id; - int datax, datay, dataz; - u8 ctrl, mode, range, intr_status; + int datax, datay, dataz, intr_status; + u8 ctrl, mode, range; intr_status = CMA3000_READ(data, CMA3000_INTSTATUS, "interrupt status"); if (intr_status < 0) -- 1.7.5.4
| |