lkml.org 
[lkml]   [2011]   [Dec]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[PATCH] perf tools: bad lookup in perf_evlist__equal()?
Fix lookup in perf_evlist__equal()

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
tools/perf/builtin-record.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

Unless this was a feature, but then a comment might be nice
This was introduced in a91e5431d54f5

diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c
index 6ab58cc..4ccb7d0 100644
--- a/tools/perf/builtin-record.c
+++ b/tools/perf/builtin-record.c
@@ -252,7 +252,7 @@ static bool perf_evlist__equal(struct perf_evlist *evlist,
pair = list_entry(other->entries.next, struct perf_evsel, node);

list_for_each_entry(pos, &evlist->entries, node) {
- if (memcmp(&pos->attr, &pair->attr, sizeof(pos->attr) != 0))
+ if (memcmp(&pos->attr, &pair->attr, sizeof(pos->attr)) != 0)
return false;
pair = list_entry(pair->node.next, struct perf_evsel, node);
}

\
 
 \ /
  Last update: 2011-12-12 20:51    [W:0.028 / U:0.140 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site