Messages in this thread | | | Date | Sun, 27 Nov 2011 11:35:29 +0000 | From | Mark Brown <> | Subject | Re: [PATCH] regulator: Avoid potential NULL dereference in reg_fixed_voltage_probe() |
| |
On Sun, Nov 27, 2011 at 10:13:50AM +0800, Axel Lin wrote:
> - if (pdev->dev.of_node) > + if (pdev->dev.of_node) { > config = of_get_fixed_voltage_config(&pdev->dev); > + if (!config) > + return -ENOMEM; > + }
Looking at this I'm thinking it's better to just drop the check for of_node entirely and just let of_get_fixed_voltage_config() fail to find what it needs.
| |