lkml.org 
[lkml]   [2011]   [Nov]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] regulator: Avoid potential NULL dereference in reg_fixed_voltage_probe()
On Sun, Nov 27, 2011 at 10:13:50AM +0800, Axel Lin wrote:

> - if (pdev->dev.of_node)
> + if (pdev->dev.of_node) {
> config = of_get_fixed_voltage_config(&pdev->dev);
> + if (!config)
> + return -ENOMEM;
> + }

Looking at this I'm thinking it's better to just drop the check for
of_node entirely and just let of_get_fixed_voltage_config() fail to find
what it needs.


\
 
 \ /
  Last update: 2011-11-27 12:37    [W:0.055 / U:1.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site