Messages in this thread Patch in this message | | | Subject | [PATCH] regulator: Avoid potential NULL dereference in reg_fixed_voltage_probe() | From | Axel Lin <> | Date | Sun, 27 Nov 2011 10:13:50 +0800 |
| |
of_get_fixed_voltage_config() may return NULL, return -ENOMEM in this case so we don't dereference NULL pointer.
Signed-off-by: Axel Lin <axel.lin@gmail.com> --- drivers/regulator/fixed.c | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/drivers/regulator/fixed.c b/drivers/regulator/fixed.c index 639e19d..2f917a1 100644 --- a/drivers/regulator/fixed.c +++ b/drivers/regulator/fixed.c @@ -166,8 +166,11 @@ static int __devinit reg_fixed_voltage_probe(struct platform_device *pdev) struct fixed_voltage_data *drvdata; int ret; - if (pdev->dev.of_node) + if (pdev->dev.of_node) { config = of_get_fixed_voltage_config(&pdev->dev); + if (!config) + return -ENOMEM; + } drvdata = kzalloc(sizeof(struct fixed_voltage_data), GFP_KERNEL); if (drvdata == NULL) { -- 1.7.5.4
| |