Messages in this thread Patch in this message | | | Subject | [PATCH] aoe: Use kmemdup rather than duplicating its implementation | From | Thomas Meyer <> | Date | Thu, 17 Nov 2011 23:43:40 +0100 |
| |
The semantic patch that makes this change is available in scripts/coccinelle/api/memdup.cocci.
Signed-off-by: Thomas Meyer <thomas@m3y3r.de> ---
diff -u -p a/drivers/block/aoe/aoechr.c b/drivers/block/aoe/aoechr.c --- a/drivers/block/aoe/aoechr.c 2011-11-07 19:39:05.287793252 +0100 +++ b/drivers/block/aoe/aoechr.c 2011-11-08 10:37:35.225430670 +0100 @@ -134,13 +134,12 @@ bail: spin_unlock_irqrestore(&emsgs_loc return; } - mp = kmalloc(n, GFP_ATOMIC); + mp = kmemdup(msg, n, GFP_ATOMIC); if (mp == NULL) { printk(KERN_ERR "aoe: allocation failure, len=%ld\n", n); goto bail; } - memcpy(mp, msg, n); em->msg = mp; em->flags |= EMFL_VALID; em->len = n;
| |