Messages in this thread | | | Subject | RE: [PATCH 1/3] mtd/nand: fix coding style issue in drivers/mtd/nand/fsl_elbc.c | Date | Tue, 15 Nov 2011 14:51:09 -0000 | From | "David Laight" <> |
| |
> On Tue, 2011-11-15 at 11:26 +0000, Jenkins, Clive wrote: > > > fix whitespaces,tabs coding style issue and ... > > > > In my opinion this code was already correct, and would display correctly > > at any TAB setting. This patch changes it so that it displays > > incorrectly at all TAB settings other than 8. > > Any tab setting other than 8 is incorrect and should not be used for > Linux code. If I view it in a proportionally-spaced font, > it's not going to line up right either. Fix your editor, if that's an issue for you.
Personally I don't even attempt to line up argumants on continuation lines - it just wastes vertical space. I just indent them as any other continuation line, so double-indent if using 4-char indents and 1/2 indent for 8-char indents.
Tabs have to be assumed to be 8 columns, otherwise all sorts of tools just get it wrong. (Or you ban tabs from source files.)
David
| |