Messages in this thread | | | Subject | RE: [PATCH 1/3] mtd/nand: fix coding style issue in drivers/mtd/nand/fsl_elbc.c | Date | Tue, 15 Nov 2011 14:42:25 -0000 | From | "Jenkins, Clive" <> |
| |
> > > fix whitespaces,tabs coding style issue and ... > > > > In my opinion this code was already correct, and would display correctly > > at any TAB setting. This patch changes it so that it displays > > incorrectly at all TAB settings other than 8. > > Any tab setting other than 8 is incorrect and should not be used for > Linux code.
This may be your (not so humble :-) opinion, and I happen to agree that a tab setting of 8 is best, usually. However, as Linus says in his coding style document "Coding style is very personal, and I won't _force_ my views on anybody".
> ... Fix your editor, if that's an issue for you.
My editor has a tab setting of 8, but readers of this list have diverse email clients, some of which do not display 8 spaces per tab.
Clive
| |