lkml.org 
[lkml]   [2011]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRE: [PATCH 5/6] arm/tegra: pinmux tables and definitions for tegra30
Peter De Schrijver wrote at Tuesday, October 25, 2011 10:54 AM:
> Define the pinmuxing and pindrive tables for tegra30. The pinmux table defines
> the available functions for each pinmux group. The pindrive table defines the
> default pullup or pulldowns for each group.

This is almost fine.

You added some new fields to struct tegra_pingroup_desc. This should be
noted in the change description, pointing out that there are new HW
features on Tegra30, but that the driver hasn't been updated to support
them. You probably want to actually add those new fields in a separate
patch before-hand, so you can modify pinmux-tegra20-tables.c to set all
those reg fields to -1, so if/when the driver does support the fields,
Tegra20 will indicate it doesn't support those parameters.

--
nvpublic



\
 
 \ /
  Last update: 2011-10-27 22:21    [from the cache]
©2003-2011 Jasper Spaans