lkml.org 
[lkml]   [2011]   [Jan]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    SubjectRE: [064/152] driver/net/benet: fix be_cmd_multicast_set() memcpy bug
    The patch below is fine. Thanks.

    -Sathya

    -----Original Message-----
    From: Greg KH [mailto:gregkh@suse.de]
    Sent: Thursday, January 06, 2011 5:53 AM
    To: linux-kernel@vger.kernel.org; stable@kernel.org
    Cc: stable-review@kernel.org; torvalds@linux-foundation.org; akpm@linux-foundation.org; alan@lxorguk.ukuu.org.uk; Perla, Sathya; Seetharaman, Subramanian; Bandi, Sarveshwar; Khaparde, Ajit; Joe Jin; David S. Miller
    Subject: [064/152] driver/net/benet: fix be_cmd_multicast_set() memcpy bug

    2.6.36-stable review patch. If anyone has any objections, please let us know.

    ------------------


    From: Joe Jin <joe.jin@oracle.com>

    [ Upstream commit 3fd40d0ceac9c234243730f4d7a6ffdb2fd3023a ]

    Regarding benet be_cmd_multicast_set() function, now using
    netdev_for_each_mc_addr() helper for mac address copy, but
    when copying to req->mac[] did not increase of the index.

    Cc: Sathya Perla <sathyap@serverengines.com>
    Cc: Subbu Seetharaman <subbus@serverengines.com>
    Cc: Sarveshwar Bandi <sarveshwarb@serverengines.com>
    Cc: Ajit Khaparde <ajitk@serverengines.com>
    Signed-off-by: Joe Jin <joe.jin@oracle.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    ---
    drivers/net/benet/be_cmds.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/net/benet/be_cmds.c
    +++ b/drivers/net/benet/be_cmds.c
    @@ -1179,7 +1179,7 @@ int be_cmd_multicast_set(struct be_adapt

    i = 0;
    netdev_for_each_mc_addr(ha, netdev)
    - memcpy(req->mac[i].byte, ha->addr, ETH_ALEN);
    + memcpy(req->mac[i++].byte, ha->addr, ETH_ALEN);
    } else {
    req->promiscuous = 1;
    }



    \
     
     \ /
      Last update: 2011-01-06 06:33    [W:0.035 / U:0.036 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site