lkml.org 
[lkml]   [2011]   [Jan]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[065/152] bonding: Fix slave selection bug.
    2.6.36-stable review patch.  If anyone has any objections, please let us know.

    ------------------


    From: Hillf Danton <dhillf@gmail.com>

    [ Upstream commit af3e5bd5f650163c2e12297f572910a1af1b8236 ]

    The returned slave is incorrect, if the net device under check is not
    charged yet by the master.

    Signed-off-by: Hillf Danton <dhillf@gmail.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    ---
    drivers/net/bonding/bonding.h | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    --- a/drivers/net/bonding/bonding.h
    +++ b/drivers/net/bonding/bonding.h
    @@ -240,11 +240,11 @@ static inline struct slave *bond_get_sla

    bond_for_each_slave(bond, slave, i) {
    if (slave->dev == slave_dev) {
    - break;
    + return slave;
    }
    }

    - return slave;
    + return 0;
    }

    static inline struct bonding *bond_get_bond_by_slave(struct slave *slave)



    \
     
     \ /
      Last update: 2011-01-06 01:59    [W:0.020 / U:0.056 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site