Messages in this thread Patch in this message | | | Subject | [PATCH] sched: fix struct autogroup memory leak | From | Mike Galbraith <> | Date | Wed, 05 Jan 2011 11:11:25 +0100 |
| |
Seems I lost a change somewhere, leaking memory.
sched: fix struct autogroup memory leak
Add missing change to actually use autogroup_free().
Signed-off-by: Mike Galbraith <efault@gmx.de> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl> Cc: Ingo Molnar <mingo@elte.hu>
--- kernel/sched.c | 1 + kernel/sched_autogroup.c | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-)
Index: linux-2.6/kernel/sched.c =================================================================== --- linux-2.6.orig/kernel/sched.c +++ linux-2.6/kernel/sched.c @@ -8382,6 +8382,7 @@ static void free_sched_group(struct task { free_fair_sched_group(tg); free_rt_sched_group(tg); + autogroup_free(tg); kfree(tg); } Index: linux-2.6/kernel/sched_autogroup.c =================================================================== --- linux-2.6.orig/kernel/sched_autogroup.c +++ linux-2.6/kernel/sched_autogroup.c @@ -20,7 +20,8 @@ static void autogroup_init(struct task_s static inline void autogroup_free(struct task_group *tg) { - kfree(tg->autogroup); + if (tg->autogroup) + kfree(tg->autogroup); } static inline void autogroup_destroy(struct kref *kref)
| |