lkml.org 
[lkml]   [2010]   [Sep]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[PATCH] i386: make kernel_execve() suitable for stack unwinding
The explicit saving and restoring of %ebx was confusing stack unwind
data consumers, and it is plain unnecessary to do this within the
asm(), since that was only introduced for PIC user mode consumers of
the original _syscall3() macro this was derived from.

Signed-off-by: Jan Beulich <jbeulich@novell.com>
Cc: Arnd Bergmann <arnd@arndb.de>

---
arch/x86/kernel/sys_i386_32.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

--- linux-2.6.36-rc3/arch/x86/kernel/sys_i386_32.c
+++ 2.6.36-rc3-i386-unwind-annotations/arch/x86/kernel/sys_i386_32.c
@@ -33,8 +33,8 @@ int kernel_execve(const char *filename,
const char *const envp[])
{
long __res;
- asm volatile ("push %%ebx ; movl %2,%%ebx ; int $0x80 ; pop %%ebx"
+ asm volatile ("int $0x80"
: "=a" (__res)
- : "0" (__NR_execve), "ri" (filename), "c" (argv), "d" (envp) : "memory");
+ : "0" (__NR_execve), "b" (filename), "c" (argv), "d" (envp) : "memory");
return __res;
}




\
 
 \ /
  Last update: 2010-09-02 15:05    [W:2.034 / U:0.416 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site