lkml.org 
[lkml]   [2010]   [Sep]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH] scripts/checkpatch.pl: Add warnings for static char that could be static const char
    From
    Date
    On Fri, 2010-09-10 at 10:06 +0100, Andy Whitcroft wrote:
    > On Thu, Sep 09, 2010 at 03:24:14PM -0400, Mike Frysinger wrote:
    > > On Thu, Sep 9, 2010 at 15:21, Joe Perches wrote:
    > > > Add warnings for possible missing const uses of
    > > > static char foo[] = "bar"
    > > > that could be
    > > > static const char foo[] = "bar"
    > > > and
    > > > static const char *foo[] = {"bar", "baz"}
    > > > that could be
    > > > static const char * const foo[] = {"bar", "baz"}
    > > guess you missed my last e-mail about not bothering checking the
    > > static or the contents :)
    > > > + if ($line =~ /\bconst\s+char\s*\*\s*(\w+)\s*\[\s*\]/) {
    > > -mike
    > Could you elucidate on that comment Mike, perhaps copy those comments
    > here.

    Mike thinks that any time there is a char array declaration
    with a default value like
    [static] char foo[] = "bar";
    or
    [static] [const] char *foo[] = {"bar", ...};

    checkpatch should issue a "use const" warning.

    http://lkml.org/lkml/2010/9/9/205

    Maybe. Maybe not. I don't like unnecessary warnings for
    functional code. I think it depends on how often those
    initialized strings are actually modified post declaration.

    If it's a _really_ high percentage, then OK, sure.




    \
     
     \ /
      Last update: 2010-09-10 11:33    [W:0.020 / U:29.916 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site