lkml.org 
[lkml]   [2010]   [Sep]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [rfc patch] treewide: Convert "static const char <*> foo[] =" to "static const char <*> const foo[] ="
    On Thu, Sep 9, 2010 at 14:48, Joe Perches wrote:
    > On Thu, 2010-09-09 at 14:29 -0400, Mike Frysinger wrote:
    >> this is going to keep
    >> creeping back in with new drivers unless we have something like
    >> checkpatch.pl catching it ...
    >
    > These are added pretty slowly, but both of
    >
    >        static char foo[] = "bar"
    > and
    >        static const char *foo[] = {"bar"}
    >
    > could be warned by checkpatch

    i dont think you even need to check the contents. just match the base:
    char foo[]
    const char *foo[]

    we want to catch these even if it isnt static, and catching the
    forward decl would be useful too.

    >> where is the actual patch ?
    >
    > On my computer.  300KB is pretty big to post.
    > I'll sent it to you separately.

    thanks. for reviewing/merging, probably be best to split up by
    subsystem. the MTD parts look straight forward (part probe types), so
    that'd be one big change. i'd even include the board changes in that
    one commit.

    same goes for the ASoC changes (most everything under sound/). looks
    sane, so make one chunk for that and send to the ASoC guys.

    your perl hack isnt quite right. the change to
    drivers/mtd/maps/ixp2000.c and intel_vr_nor.c incorrectly ate leading
    whitespace. how about making a coccinelle patch ? then you could add
    it to scripts/coccinelle/ for other people to use in the future, and
    hopefully these style changes wouldnt be broken in the process.
    -mike
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2010-09-09 21:19    [W:0.030 / U:31.276 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site