lkml.org 
[lkml]   [2010]   [Aug]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 09/15] Despecificate driver from iLO2
    Hi Dan,

    > This driver supports both iLO2 and iLO3, but our user-visible strings
    > currently only reference iLO2. Let's just call it "iLO" to avoid having
    > to update strings for each iLO generation. This driver doesn't support
    > iLO ASICs prior to iLO2, but that is sufficiently explained in Kconfig.

    Just a thought: Wouldn't it be more consistent if it's called iLO2+ everywhere?

    > - tristate "HP Proliant iLO 2 Hardware Watchdog Timer"
    > + tristate "HP Proliant iLO Hardware Watchdog Timer"

    would be: tristate "HP Proliant iLO2+ Hardware Watchdog Timer"

    > - .identity = "HP iLO2 HW Watchdog Timer",
    > + .identity = "HP iLO HW Watchdog Timer",

    and: .identity = "HP iLO2+ HW Watchdog Timer",

    > - * First let's find out if we are on an iLO2 server. We will
    > + * First let's find out if we are on an iLO2+ server. We will

    > - dev_warn(&dev->dev,
    > - "This server does not have an iLO2 ASIC.\n");
    > + dev_warn(&dev->dev, "This server does not have an iLO ASIC"
    > + " version 2 or greater.\n");

    dev_warn(&dev->dev,
    "This server does not have an iLO2+ ASIC.\n");

    > - "Unable to detect the iLO2 server memory.\n");
    > + "Unable to detect the iLO server memory.\n");

    "Unable to detect the iLO2+ server memory.\n");

    For the rest I'm still reviewing the code.

    Kind regards,
    Wim.



    \
     
     \ /
      Last update: 2010-08-04 22:17    [W:0.026 / U:29.600 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site