Messages in this thread | | | Date | Tue, 8 Jun 2010 08:32:26 +0200 | From | Antonio Ospite <> | Subject | Re: [PATCH] HID: Add Support for Setting and Getting Feature Reports from hidraw |
| |
On Mon, 7 Jun 2010 23:51:48 -0400 Alan Ott <alan@signal11.us> wrote:
> Per the HID Specification, Feature reports must be sent and received on > the Configuration endpoint (EP 0) through the Set_Report/Get_Report > interfaces. This patch adds two ioctls to hidraw to set and get feature > reports to and from the device. Modifications were made to hidraw and > usbhid. > > New hidraw ioctls: > HIDIOCSFEATURE - Perform a Set_Report transfer of a Feature report. > HIDIOCGFEATURE - Perform a Get_Report transfer of a Feature report. > > Signed-off-by: Alan Ott <alan@signal11.us> > ---
Thanks Alan, I am going to test this quite soon.
TBH, when I was thinking about how to extend hidraw I thought we could have added a new report_type field to struct hidraw_report_descriptor, in order to re-use the HIDIOCGRDESC ioctl handler itself, adding then a HIDIOCSRDESC for setting the report. This looked cleaner to my eyes, but I didn't actually implement this, so I don't know if it was feasible, for instance one problem I didn't investigate further was about the default value of the aforementioned report_type field in order to keep the current behavior of HIDIOCGRDESC.
Regards, Antonio.
-- Antonio Ospite http://ao2.it
PGP public key ID: 0x4553B001
A: Because it messes up the order in which people normally read text. See http://en.wikipedia.org/wiki/Posting_style Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail? [unhandled content-type:application/pgp-signature] | |