Messages in this thread Patch in this message | | | Date | Thu, 3 Jun 2010 12:04:02 +0200 | From | Dan Carpenter <> | Subject | [patch] fcntl: return -EFAULT if copy_to_user fails |
| |
copy_to_user() returns the number of bytes remaining, but we want to return -EFAULT.
ret = fcntl(fd, F_SETOWN_EX, NULL);
With the original code ret would be 8 here.
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/fs/fcntl.c b/fs/fcntl.c index f74d270..0ea7b0f 100644 --- a/fs/fcntl.c +++ b/fs/fcntl.c @@ -274,7 +274,7 @@ static int f_setown_ex(struct file *filp, unsigned long arg) ret = copy_from_user(&owner, owner_p, sizeof(owner)); if (ret) - return ret; + return -EFAULT; switch (owner.type) { case F_OWNER_TID:
| |