Messages in this thread | | | Date | Fri, 25 Jun 2010 09:07:39 -0500 (CDT) | From | Christoph Lameter <> | Subject | Re: [PATCH 1/2] vmscan: shrink_slab() require number of lru_pages, not page order |
| |
On Fri, 25 Jun 2010, KOSAKI Motohiro wrote:
> Fix simple argument error. Usually 'order' is very small value than > lru_pages. then it can makes unnecessary icache dropping.
This is going to reduce the delta that is added to shrinker->nr significantly thereby increasing the number of times that shrink_slab() is called.
What does the "lru_pages" parameter do in shrink_slab()? Looks like its only role is as a divison factor in a complex calculation of pages to be scanned.
do_try_to_free_pages passes 0 as "lru_pages" to shrink_slab() when trying to do cgroup lru scans. Why is that?
| |