lkml.org 
[lkml]   [2010]   [Jun]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 1/2] vmscan: shrink_slab() require number of lru_pages, not page order
    Date
    Fix simple argument error. Usually 'order' is very small value than
    lru_pages. then it can makes unnecessary icache dropping.

    Cc: Christoph Lameter <cl@linux-foundation.org>
    Cc: Rik van Riel <riel@redhat.com>
    Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
    ---
    mm/vmscan.c | 3 ++-
    1 files changed, 2 insertions(+), 1 deletions(-)

    diff --git a/mm/vmscan.c b/mm/vmscan.c
    index 0ebfe12..c927948 100644
    --- a/mm/vmscan.c
    +++ b/mm/vmscan.c
    @@ -2611,6 +2611,7 @@ static int __zone_reclaim(struct zone *zone, gfp_t gfp_mask, unsigned int order)

    slab_reclaimable = zone_page_state(zone, NR_SLAB_RECLAIMABLE);
    if (slab_reclaimable > zone->min_slab_pages) {
    + unsigned long lru_pages = zone_reclaimable_pages(zone);
    /*
    * shrink_slab() does not currently allow us to determine how
    * many pages were freed in this zone. So we take the current
    @@ -2621,7 +2622,7 @@ static int __zone_reclaim(struct zone *zone, gfp_t gfp_mask, unsigned int order)
    * Note that shrink_slab will free memory on all zones and may
    * take a long time.
    */
    - while (shrink_slab(sc.nr_scanned, gfp_mask, order) &&
    + while (shrink_slab(sc.nr_scanned, gfp_mask, lru_pages) &&
    zone_page_state(zone, NR_SLAB_RECLAIMABLE) >
    slab_reclaimable - nr_pages)
    ;
    --
    1.6.5.2




    \
     
     \ /
      Last update: 2010-06-25 13:23    [W:0.020 / U:59.980 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site