Messages in this thread Patch in this message | | | Date | Thu, 17 Jun 2010 10:15:10 -0700 | From | "Justin P. Mattock" <> | Subject | Re: [PATCH 3/5]pci:bus.c Fix variable 'retval' set but not used |
| |
On 06/15/2010 11:07 PM, Junchang Wang wrote: > On Tue, Jun 15, 2010 at 10:33:52PM -0700, Justin P. Mattock wrote: >> @@ -234,12 +234,10 @@ void pci_bus_add_devices(const struct pci_bus *bus) >> void pci_enable_bridges(struct pci_bus *bus) >> { >> struct pci_dev *dev; >> - int retval; >> >> list_for_each_entry(dev,&bus->devices, bus_list) { >> if (dev->subordinate) { >> if (!pci_is_enabled(dev)) { >> - retval = pci_enable_device(dev); > Hi Justin, > > pci_enable_device initializes device before it's used by a driver. > > I think you should add check instead of eliminating pci_enable_device. > > For example, > retval = pci_enable_device(dev); > if (retval< 0) { > goto handle_err; > } > > --Junchang > >
o.k. I looked into this one, as well as the scsi, please have a look when you have time and let me know what you think:
--- drivers/pci/bus.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/drivers/pci/bus.c b/drivers/pci/bus.c index 628ea20..dba4c28 100644 --- a/drivers/pci/bus.c +++ b/drivers/pci/bus.c @@ -240,6 +240,9 @@ void pci_enable_bridges(struct pci_bus *bus) if (dev->subordinate) { if (!pci_is_enabled(dev)) { retval = pci_enable_device(dev); + if (retval < 0) { + dev_err(&dev->dev, "maybe something here explaining something...\n"); + } pci_set_master(dev); } pci_enable_bridges(dev->subordinate);
Justin P. Mattock
| |