lkml.org 
[lkml]   [2010]   [Jun]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 3/5]pci:bus.c Fix variable 'retval' set but not used
    On 06/15/2010 11:07 PM, Junchang Wang wrote:
    > On Tue, Jun 15, 2010 at 10:33:52PM -0700, Justin P. Mattock wrote:
    >> @@ -234,12 +234,10 @@ void pci_bus_add_devices(const struct pci_bus *bus)
    >> void pci_enable_bridges(struct pci_bus *bus)
    >> {
    >> struct pci_dev *dev;
    >> - int retval;
    >>
    >> list_for_each_entry(dev,&bus->devices, bus_list) {
    >> if (dev->subordinate) {
    >> if (!pci_is_enabled(dev)) {
    >> - retval = pci_enable_device(dev);
    > Hi Justin,
    >
    > pci_enable_device initializes device before it's used by a driver.
    >
    > I think you should add check instead of eliminating pci_enable_device.
    >
    > For example,
    > retval = pci_enable_device(dev);
    > if (retval< 0) {
    > goto handle_err;
    > }
    >
    > --Junchang
    >
    >

    this gets it to compile with no warning. although not sure if correct.

    if (dev->subordinate) {
    if (!pci_is_enabled(dev)) {
    retval = pci_enable_device(dev);
    if (retval)
    printk("test...\n");
    pci_set_master(dev);
    }
    pci_enable_bridges(dev->subordinate);
    }

    Justin P. Mattock


    \
     
     \ /
      Last update: 2010-06-16 19:03    [W:0.025 / U:180.936 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site