[lkml]   [2010]   [Jun]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH] fs: run emergency remount on dedicated workqueue

    On 06/02/2010 01:57 AM, Linus Torvalds wrote:
    > On Tue, 1 Jun 2010, Andrew Morton wrote:
    >> Please, always quote the patch title rather than a bare commit ID. The
    >> usual form is
    >> fa4b9074cd8428958c2adf9dc0c831f46e27c193 ("buffer: make
    >> invalidate_bdev() drain all percpu LRU add caches:)
    >> The main reason for this is so that people can more reliably and simply
    >> identify the patch within a different tree. I think.
    > Absolutely. Also, I think it's usually more readable to quote just the
    > first 12 hex digits of the SHA1 - that's still going to be perfectly
    > unique in any practical situation, and makes it way easier to flow the
    > text to be readable.

    Alright, will do so from now on.

    >> gaah. Do we really want to add Yet Another Kernel Thread just for that
    >> dopey sysrq-U thing?
    > I do have to agree that it's disgusting. Can't we use an existing thread
    > (slow-work?) or something like that?

    The dedicated workqueue can go away with cmwq. As it's a temporary
    measure until then, I wanted to keep it simple. Would it be okay if I
    note that the dedicated workqueue will go away soonish in the patch
    description and comment?



     \ /
      Last update: 2010-06-02 02:17    [W:0.022 / U:3.948 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site