Messages in this thread | | | Date | Fri, 23 Apr 2010 08:07:34 -0700 | From | Greg KH <> | Subject | Re: USBIP (staging) driver's dependency on drivers/usb/core internal headers |
| |
On Fri, Apr 23, 2010 at 12:44:11PM +0200, Eric Lescouet wrote: > Hi, > > The USBIP modules (and some others) have a direct dependency on the following headers: > - drivers/usb/core/hdc.h (struct usb_hcd and various routines) > - drivers/usb/core/hub.h (couple of constants) > Because those headers are not part of include/, it makes it quite difficult > to compile them as standalone modules (e.g.: against pre-compiled kernel).
Then don't do that :)
> hdc.c and hub.c are relatively self-contained and could be moved to e.g.: include/linux/usb/. > > What do you think?
I think the code needs to be cleaned up and merged to the main part of the kernel tree, then this wouldn't be an issue, right?
Also, please cc: the linux-usb@vger.kernel.org list for USB related things in the future.
thanks,
greg k-h
| |