[lkml]   [2010]   [Apr]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: USBIP (staging) driver's dependency on drivers/usb/core internal headers
    Greg KH wrote:
    > On Fri, Apr 23, 2010 at 11:52:26AM -0400, Alan Stern wrote:
    >> On Fri, 23 Apr 2010, Greg KH wrote:
    >>> On Fri, Apr 23, 2010 at 12:44:11PM +0200, Eric Lescouet wrote:
    >>>> Hi,
    >>>> The USBIP modules (and some others) have a direct dependency on the following headers:
    >>>> - drivers/usb/core/hdc.h (struct usb_hcd and various routines)
    >>>> - drivers/usb/core/hub.h (couple of constants)
    >>>> Because those headers are not part of include/, it makes it quite difficult
    >>>> to compile them as standalone modules (e.g.: against pre-compiled kernel).
    >>> Then don't do that :)
    >>>> hdc.c and hub.c are relatively self-contained and could be moved to e.g.: include/linux/usb/.
    >>>> What do you think?
    >>> I think the code needs to be cleaned up and merged to the main part of
    >>> the kernel tree, then this wouldn't be an issue, right?
    >> I think moving hub.h into include/linux/usb would be a good thing.
    >> However, if this is done then the file contents should be rearranged
    >> slightly:
    >> Everything from the "Hub request types" comment through the
    >> various HUB_TTTT_* definitions (except the line declaring
    >> struct usb_device) should be extracted into a separate file.
    >> This new file could be called ch11.h (because it contains
    >> constants and structures from Chapter 11 of the USB 2.0 spec,
    >> just as ch9.h contains information from Chapter 9) or it
    >> could keep the name hub.h. It could even be exported as
    >> a userspace header file.
    >> The remainder (not very much) should be merged into hcd.h.
    >> Once that's done, moving hcd.h into include/linux/usb would be a
    >> reasonable thing to do as well. It is shared between usbcore and the
    >> HCDs, so it really does belong in a more public location.
    > Ok, fair enough. Patches are always welcome :)
    > thanks,
    > greg k-h

    If I understand correctly, splitting hub.h into hub.h + ch11.h is
    independent of the move. At the end the 2 (or 3 files) would end up
    into include/linux/usb/.

    I've tried to move hub.h and hcd.h and to compile the kernel, already.
    Changing the path of the #include directives in ~40 files did the trick.

    Would you like 2 patches (move and then split) or only 1?


     \ /
      Last update: 2010-04-23 18:35    [W:0.024 / U:5.932 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site