lkml.org 
[lkml]   [2010]   [Apr]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 3/3] p9auth: add p9auth driver
Date
Serge E. Hallyn <serue@us.ibm.com> wrote:

> + if (ret == 0)
> + commit_creds(new);
> + else
> + abort_creds(new);
> +
> + return ret;

If you make this:

if (ret == 0)
return commit_creds(new);
abort_creds(new);
return ret;
then gcc can tail-call commit_creds(), which is guaranteed to return 0.

David


\
 
 \ /
  Last update: 2010-04-21 12:53    [from the cache]
©2003-2011 Jasper Spaans