lkml.org 
[lkml]   [2010]   [Apr]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 1/4] blkdev: pass gfp_mask and flags to blkdev_issue_flush
Date
Christoph Hellwig <hch@infradead.org> writes:

>> +enum{
>> + __BLKDEV_IFL_WAIT, /* wait for completion */
>> + __BLKDEV_IFL_BARRIER, /*issue request with barrier */
>> +};
>> +#define BLKDEV_IFL_WAIT (1 << __BLKDEV_IFL_WAIT)
>> +#define BLKDEV_IFL_BARRIER (1 << __BLKDEV_IFL_BARRIER)
>
> This is a very awkward stayle to define flags. There really should
> be no need for the __-prefixed version. While you're using them for
> test/set_bit and co there's no reason to use these atomic bitops here.
I need both bit_num(used inside function) and flag (1<<bit_num)
which is used by function caller.
No problem, i'll change it whenever you like
do you like following?
enum{
IFN_BLKDEV_WAIT, /* wait for completion */
IFN_BLKDEV_BARRIER, /*issue request with barrier */
};
#define BLKDEV_WAIT (1 << IFN_BLKDEV_WAIT)
#define BLKDEV_BARRIER (1 << IFN_BLKDEV_BARRIER)


\
 
 \ /
  Last update: 2010-04-14 08:21    [W:0.066 / U:0.848 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site